Skip to content

chore: split toolbar into v1 and v2 placeholder#845

Merged
thomaswhyyou merged 12 commits intomainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-5
Feb 13, 2026
Merged

chore: split toolbar into v1 and v2 placeholder#845
thomaswhyyou merged 12 commits intomainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-5

Conversation

@thomaswhyyou
Copy link
Contributor

@thomaswhyyou thomaswhyyou commented Feb 2, 2026

Description

This PR re-organizes the existing toolbar component, so that we now have V1 (the existing toolbar) and V2 (a placeholder component for the new toolbar), with certain modules shared between the two:

Toolbar/
├── index.ts
├── KnockButton.tsx
├── shared.ts
├── styles.css
├── V1
│   ├── index.ts
│   └── V1.tsx
└── V2
    ├── GuideHoverCard.tsx
    ├── GuideRow.tsx
    ├── GuidesListDisplaySelect.tsx
    ├── helpers.ts
    ├── index.ts
    ├── useInspectGuideClientStore.ts
    └── V2.tsx

Also includes more prep work:

  • Adds a toolbar prop to KnockGuideProvider to allow opting into using the new toolbar "v2", while the development continues
  • Adds a trackDebugParams prop to KnockGuideProvider and the guide client, so we can turn off reading/writing debug params from the guide client when using the toolbar.
    • This is paving a path toward pulling out the bulk of the debug logic out of the guide client, and moving it to the toolbar modules to tame complexity in the guide client code
  • Adds a placeholder component for toolbar v2, that can render based on the knock_guide_toolbar query param and exit out of it.
CleanShot.2026-02-04.at.15.37.52.mp4
Cursor Bugbot reviewed your changes and found no issues for commit 1b10cb1

@linear
Copy link

linear bot commented Feb 2, 2026

@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 13, 2026 1:18am
javascript-nextjs-example Ready Ready Preview, Comment Feb 13, 2026 1:18am
javascript-slack-connect-example Ready Ready Preview, Comment Feb 13, 2026 1:18am
javascript-slack-kit-example Ready Ready Preview, Comment Feb 13, 2026 1:18am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

⚠️ No Changeset found

Latest commit: 85c3ab7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from 968d4b2 to ac879d5 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-4 branch from 9c6bd46 to 34821df Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou changed the base branch from thomas-kno-11142-sdk-guide-toolbar-v2-poc-4 to graphite-base/845 February 2, 2026 20:47
@thomaswhyyou thomaswhyyou changed the title split out toolbar into v1 and v2 chore: split toolbar into v1 and v2 Feb 2, 2026
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from ac879d5 to 84f9e9e Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-5 branch from 84f9e9e to 0ebc110 Compare February 3, 2026 19:09
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 37.82383% with 120 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.97%. Comparing base (9c0e9d0) to head (85c3ab7).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 15.38% 66 Missing ⚠️
...c/modules/guide/components/Toolbar/KnockButton.tsx 10.00% 36 Missing ⚠️
...src/modules/guide/components/Toolbar/V2/helpers.ts 27.27% 8 Missing ⚠️
...src/modules/guide/providers/KnockGuideProvider.tsx 20.00% 8 Missing ⚠️
packages/client/src/clients/guide/client.ts 97.43% 1 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V1/V1.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   68.45%   67.97%   -0.49%     
==========================================
  Files         193      199       +6     
  Lines        8053     8194     +141     
  Branches     1066     1075       +9     
==========================================
+ Hits         5513     5570      +57     
- Misses       2515     2599      +84     
  Partials       25       25              
Files with missing lines Coverage Δ
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)
...e/src/modules/guide/context/KnockGuideProvider.tsx 96.49% <100.00%> (+0.19%) ⬆️
packages/react/src/index.ts 100.00% <ø> (ø)
...t/src/modules/guide/components/Toolbar/V1/index.ts 100.00% <100.00%> (ø)
...t/src/modules/guide/components/Toolbar/V2/index.ts 100.00% <100.00%> (ø)
...eact/src/modules/guide/components/Toolbar/index.ts 100.00% <100.00%> (ø)
...act/src/modules/guide/components/Toolbar/shared.ts 100.00% <100.00%> (ø)
...ckages/react/src/modules/guide/components/index.ts 100.00% <100.00%> (ø)
packages/react/src/modules/guide/index.ts 100.00% <ø> (ø)
packages/client/src/clients/guide/client.ts 88.85% <97.43%> (+0.20%) ⬆️
... and 5 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments